Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect user's docker context endpoint during image pull #3401

Merged
merged 7 commits into from
Jan 17, 2025
Merged

feat: respect user's docker context endpoint during image pull #3401

merged 7 commits into from
Jan 17, 2025

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jan 13, 2025 •
edited
Loading

Description

This changes Zarf to automatically use the current docker context endpoint during the local docker fallback image pull on create.

Tested on Mac with Colima as a different docker context

Related Issue

Fixes #2674

Checklist before merging

AustinAbro321 and others added 5 commits January 13, 2025 20:58
@AustinAbro321
init docker cli
303eb2a 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
cleanup code
a6801d5 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
respect docker contexts
d6f70b5 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
rename
93fa2c2 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
newline
bd40aaf 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 13, 2025 21:40
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 456a66f
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/678a8119da59290008ed59fb

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/images/pull.go 50.00% 11 Missing and 5 partials ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/pull.go 54.79% <50.00%> (-0.57%) ⬇️

@AustinAbro321
merge
e270973 
Signed-off-by: Austin Abro <[email protected]>
phillebaba
phillebaba previously approved these changes Jan 17, 2025
View reviewed changes
@AustinAbro321
merge main
456a66f 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit cf155b7 Jan 17, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the support-docker-context branch January 17, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillebaba phillebaba phillebaba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zarf does not respect docker contexts
2 participants
@AustinAbro321 @phillebaba